Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbtiles summary tool cleanup #1000

Merged
merged 1 commit into from
Nov 13, 2023
Merged

mbtiles summary tool cleanup #1000

merged 1 commit into from
Nov 13, 2023

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Nov 13, 2023

After some thinking, it seems mbtiles summary (aliased as mbtiles info) would be a bit better than stats. I renamed and adjusted documentation, consolidating it in one doc page.

Other changes:

  • use file system's file size, reporting 'unknown' if needed
  • report page count
  • moved bbox computation into a separate function
  • inlined a number of things for readability

After some thinking, it seems `mbtiles summary` (aliased as `mbtiles info`) would be a bit better than stats.  I renamed and adjusted documentation, consolidating it in one doc page.

Other changes:
* use file system's file size, reporting 'unknown' if needed
* report page count
* moved bbox computation into a separate function
* inlined a number of things for readability
@nyurik nyurik requested a review from sharkAndshark November 13, 2023 07:31
@nyurik nyurik enabled auto-merge (squash) November 13, 2023 07:39
@nyurik nyurik merged commit 021cddc into maplibre:main Nov 13, 2023
18 checks passed
@nyurik nyurik deleted the summary branch November 13, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants