Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of small refactorings #1107

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Lots of small refactorings #1107

merged 1 commit into from
Dec 26, 2023

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Dec 26, 2023

  • Use Option<&T> instead of &Option<T> in function arguments.
  • Cleaner var names
  • Slight optimization of get_tile with query params
  • Split up srv/server.rs into fonts, sprites, tiles, and tiles_info files
  • better error reporting in tests

@nyurik nyurik requested a review from sharkAndshark December 26, 2023 07:17
@nyurik
Lots of small refactorings
ebf57db 
* Use `Option<&T>` instead of `&Option<T>` in function arguments.
* Cleaner var names
* Slight optimization of `get_tile` with query params
* Split up srv/server.rs into fonts, sprites, tiles, and tiles_info files
* better error reporting in tests
@nyurik nyurik enabled auto-merge (squash) December 26, 2023 07:23
@nyurik nyurik merged commit 61d3286 into maplibre:main Dec 26, 2023
18 checks passed
@nyurik nyurik deleted the refactor branch December 26, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkAndshark sharkAndshark sharkAndshark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyurik @sharkAndshark