Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pmtiles S3 urls #1477

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Support for pmtiles S3 urls #1477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
19742ce
add support for pmtiles streaming from S3 using authenticated requests
Aug 17, 2024
97388b3
cargo fmt
Aug 17, 2024
9e4f48b
add S3SourceError for S3 uri-related errors
Sep 9, 2024
c224f99
Fixed unwrapping results in s3 uri parsing
Sep 9, 2024
e895ad1
add documentation for s3 uris
Sep 9, 2024
a144f3d
Try AWS_PROFILE profile before fallbacking to default credentials
Sep 9, 2024
3b70206
add mention of using AWS_PROFILE, fill in information on how credenti…
Sep 9, 2024
5a18b12
docs formatting fixes
Nov 11, 2024
ced16fc
migrate to aws-s3-sdk backed for s3 pmtiles support
Nov 13, 2024
7eee529
update pmtiles s3 documentation
Nov 13, 2024
ec7a68c
add S3 pmtiles test
Nov 13, 2024
c82421e
remove unnecessary aws-sdk-s3 dep
Nov 13, 2024
8db2b18
run cargo fmt
Nov 13, 2024
c7daa69
fix reversed link syntax
Nov 13, 2024
6c4ee85
add support for anonymous S3 requests using AWS_NO_CREDENTIALS env var
Nov 13, 2024
16ffe93
add env variables for pmtiles s3 tests
Nov 13, 2024
eaa54ce
update docs on anonymous s3 requests
Nov 13, 2024
1ab569e
remove accidentally committed file
Nov 14, 2024
4fcf6ad
add missing env variables
Nov 18, 2024
d1ac071
fix accidental case typo
Nov 18, 2024
b3b4b31
Merge branch 'main' into pmtiles_s3
CommanderStorm Dec 16, 2024
8eb9587
fixed bad merge
CommanderStorm Dec 16, 2024
94f8d43
fixed `is_url` not allowing s3 urls
CommanderStorm Dec 16, 2024
b97b84e
added an integration testcase
CommanderStorm Dec 16, 2024
f427bbe
re-blessed the results
CommanderStorm Dec 16, 2024
831bc08
Merge branch 'main' into pmtiles_s3
CommanderStorm Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ jobs:
cargo test --doc
env:
DATABASE_URL: postgres://${{ env.PGUSER }}:${{ env.PGUSER }}@${{ env.PGHOST }}:${{ job.services.postgres.ports[5432] }}/${{ env.PGDATABASE }}?sslmode=require
AWS_NO_CREDENTIALS: 1
AWS_REGION: eu-central-1

docker-build-test:
name: Build and test docker images
Expand Down Expand Up @@ -518,6 +520,8 @@ jobs:
cargo clean
env:
DATABASE_URL: postgres://${{ env.PGUSER }}:${{ env.PGUSER }}@${{ env.PGHOST }}:${{ job.services.postgres.ports[5432] }}/${{ env.PGDATABASE }}?sslmode=${{ matrix.sslmode }}
AWS_NO_CREDENTIALS: 1
AWS_REGION: eu-central-1
- name: Save test output (on error)
if: failure()
uses: actions/upload-artifact@v4
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/grcov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ jobs:
RUSTFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests'
RUSTDOCFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests'
DATABASE_URL: postgres://${{ env.PGUSER }}@${{ env.PGHOST }}:${{ job.services.postgres.ports[5432] }}/${{ env.PGDATABASE }}
AWS_NO_CREDENTIALS: 1
AWS_REGION: eu-central-1

- name: Gather coverage data
id: coverage
Expand Down
Loading
Loading