Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unified the types to be based on TileInfoSource #1611

Merged
merged 1 commit into from
Dec 13, 2024
Merged

unified the types to be based on TileInfoSource #1611

merged 1 commit into from
Dec 13, 2024

Conversation

CommanderStorm
Copy link
Collaborator

@CommanderStorm CommanderStorm commented Dec 13, 2024 •
edited
Loading

This PR pulls the changes to Box<dyn Source> vs TileInfoSource from

nyurik
nyurik approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx

@CommanderStorm CommanderStorm merged commit 6b3da49 into maplibre:main Dec 13, 2024
18 of 19 checks passed
@CommanderStorm CommanderStorm deleted the box_src_to_tileinfosource branch December 13, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyurik nyurik nyurik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CommanderStorm @nyurik