Minor pre-commit-config change #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
approved these changes
Feb 24, 2025
.pre-commit-config.yaml
Outdated
| - id: check-toml | ||
| - id: check-yaml | ||
| - id: check-added-large-files | ||
| args: [ --allow-multiple-documents, --unsafe ] |
There was a problem hiding this comment.
Why this change?
--unsafe
Instead of loading the files, simply parse them for syntax. A syntax-only check enables extensions and unsafe constructs which would otherwise be forbidden. Using this option removes all guarantees of portability to other yaml implementations. Implies--allow-multiple-documents
There was a problem hiding this comment.
copy paste, i guess we don't need it, thx
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
CommanderStorm
added a commit
to alamminsalo/martin
that referenced
this pull request
Mar 1, 2025
Co-authored-by: Frank Elsinga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.