Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve table/view comments as tilejson #871

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

sharkAndshark
Copy link
Collaborator

Try to fix #869

@sharkAndshark sharkAndshark force-pushed the tablecomments branch 3 times, most recently from 2567a44 to 609ef42 Compare September 8, 2023 02:47
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor things

martin/src/pg/table_source.rs Outdated Show resolved Hide resolved
martin/src/pg/scripts/query_available_tables.sql Outdated Show resolved Hide resolved
@nyurik
Copy link
Member

nyurik commented Sep 8, 2023

Also, please update the docs

sharkAndshark and others added 3 commits September 8, 2023 12:11
Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
@sharkAndshark sharkAndshark marked this pull request as ready for review September 8, 2023 07:25
docs/src/sources-pg-tables.md Outdated Show resolved Hide resolved
docs/src/sources-pg-tables.md Outdated Show resolved Hide resolved
Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@sharkAndshark sharkAndshark merged commit fa1bf4b into maplibre:main Sep 12, 2023
@sharkAndshark sharkAndshark deleted the tablecomments branch September 12, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow TileJSON SQL comments on Postgres tables
2 participants