Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a homebrew CI test #917

Closed
wants to merge 3 commits into from
Closed

Add a homebrew CI test #917

wants to merge 3 commits into from

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Oct 2, 2023

Trying to automate homebrew testing, so that eventually we can be certain our mac users are ok.

HELP NEEDED: I (@nyurik) don't have a Mac.

So far I already see that it is loading a lot of un-needed (?) homebrew stuff when adding a tap - so perhaps we need to move it to another repo all-together, like maplibre/martin-homebrew ?

This PR temporarily deletes all other CIs to avoid wasting resources -- they will be re-added later.

See #618 #674

@nyurik nyurik changed the title test Add a homebrew CI test Oct 2, 2023
@sharkAndshark
Copy link
Collaborator

I have a Mac but I know nothing about homebrew packaging.. Is there any thing I could help before reading a lot of documents about homebrew?

@nyurik
Copy link
Member Author

nyurik commented Oct 2, 2023

Sorry, I know even less about homebrew :)

@sharkAndshark
Copy link
Collaborator

I'm reading docs then ..😂

@nyurik
Copy link
Member Author

nyurik commented Oct 8, 2023

So it seems the installation passes now (thanks @sharkAndshark !), so now the questions are:

  • do we want to move homebrew formular to a new repo, e.g. maplibre/martin-homebrew
  • are there any additional tests we can do?
  • is there a way to automate formula update on each release

@sharkAndshark
Copy link
Collaborator

@nyurik

  • I'm happy to move it to a standalone repo as homebrew clone whole martin repo when tapping. It can save user's disk space
  • Maybe run an integration test against a PostGIS? But we need to duplicate some test shell if we are in an new repo: maplibre/martin-homebrew..
  • Need more research on. A simple idea is use shell to parse cargo.toml?

@nyurik
Copy link
Member Author

nyurik commented Oct 9, 2023

So this is now a fairly low priority, but if you do notice how other repos structure homebrew, it would help. Seems weird if each installation env (homebrew, snap, nix, ...) would need its own repo tbh, but maybe there is a common pattern other repos follow?

@sharkAndshark
Copy link
Collaborator

How about we stay a single repo until we figure out the best practice?

@nyurik
Copy link
Member Author

nyurik commented Oct 9, 2023

sure, we can do that too. I do want to have some CI that tests & updates the code as part of the release process. Esp maybe have a regularly running (cron job) workflow that validates that homebrew still works.

@nyurik
Copy link
Member Author

nyurik commented Oct 17, 2023

already done in the homebrew-martin repo

@nyurik nyurik closed this Oct 17, 2023
@nyurik nyurik deleted the test-homebrew branch October 17, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants