Log a warning if PG startup takes too long #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
reviewed
Oct 7, 2023
martin/src/pg/config.rs
Outdated
| @@ -110,8 +114,18 @@ impl PgConfig { | |||
|
|
|||
| pub async fn resolve(&mut self, id_resolver: IdResolver) -> crate::Result<Sources> { | |||
| let pg = PgBuilder::new(self, id_resolver).await?; | |||
|
|
|||
| let instantiate_tables = pg.instantiate_tables(); | |||
| pin_mut!(instantiate_tables); | |||
There was a problem hiding this comment.
I think this should go inside the fn instantiate_tables() because otherwise you are not simultaneously instantiating tables AND functions. Instead, you instantiate tables for 5 seconds or until complet, and only then start instantiating functions.
There was a problem hiding this comment.
Sorry for the mixup there! This updated version should work as expected, but I wrapped the entire instantiate_tables function because there are multiple futures awaited inside of it and I wasn't sure the best way to go about that
pjsier
force-pushed
the
810-log-pg-startup-warning
branch
from
c2591d9 to
c8e9c0e
Compare
This makes the functionality reusable
Cleaner approach to timeout reporting
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a warning message using the suggested implementation in #810. Thanks for the recommended approach in the ticket! This one seemed straightforward enough that local tests would do, which I ran by adding a delay to
instantiate_tables.I'm getting a clippy error locally for having
Deserializeon a type with methods usingunsafe, but it looks like that might be a more significant update.Fixes #810