fix isArchived and isGlobal filtering in extendFind endpoint #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollinBeczak
changed the title
CollinBeczak
changed the title
CollinBeczak
force-pushed
the
Collin/fix-isarchived-and-isglobal-filtering
branch
from
679db6d to
5724c6e
Compare
jake-low
previously approved these changes
Feb 6, 2025
|
Will do, thanks for the review |
|
|
closing in favor of #1168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
/api/v2/challenges/extendedFindendpoint was not correctly handling archived and global challenge filtering. The issue arose because the filter condition was always evaluating asfalse. This happened because the filter was being wrapped inSome(value)(e.g.,Some(false)orSome(true)) instead of directly evaluating thevalue.Fix Details
This PR updates the condition to handle the wrapped
Some(value)correctly, ensuring that the filtering logic now behaves as expected. This resolves the bug affecting archived and global challenge filtering.