"#53 the gradle version was updated to the latest, as well the java v… #54
Conversation
…he java version"
|
Hi, I am just curious about this pull request, so I want to know if you have had the opportunity of checking it. |
|
@stianrincon .. sorry.. I'm not an expert on gradle.. Perhaps @filiphr can have a look at this.. Thanks anyway.. |
There was a problem hiding this comment.
Thanks for this update @stianrincon. This looks OK to me. However, I think that we should not up the source compatibility to 11. Was there a reason for this?
Apart from that I see that that a .DS_Store file was committed as well. Can you please remove that from your commit?
| ext { | ||
| mapstructVersion = "1.3.0.Beta2" | ||
| } | ||
|
|
||
| sourceCompatibility = JavaVersion.VERSION_1_8 | ||
| sourceCompatibility = "11" |
There was a problem hiding this comment.
Hi guys, thanks for replying, I will remove .DS_Store file. And about sourceCompatibility = 11 it was as a way to have the example with the latest java. But if it was not good I can keep it as sourceCompatibility = JavaVersion.VERSION_1_8. So @filiphr you please just let me know.
There was a problem hiding this comment.
Let's keep 1.8. We can add a comment that people can put 11 and it would work.
There was a problem hiding this comment.
+1 for these changes and getting this PR merged!
|
I just merged in another PR which goal was more or less the same. @stianrincon can you rebase your PR and see if all is correct in the master currently? If so, I guess we can close this one. Thanks for contributing. |
Hi, I was updating the Gradle version to the latest. Based on the fact that wrapper task is not needed I removed the script about wrapper but I take care of updating the gradlew and the other files so we can run the command "./gradlew clean build", finally I was updating the example for using java 11.