RD-318: propagating the beforeId option on heatmap layer helper (#112)

* propagating the beforeId option on heatmap layer helper * linting
maptiler · Sep 6, 2024 · 5f036b4 · 5f036b4
1 parent 7f4af0f
commit 5f036b4
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 23 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 ### Bug Fixes
 - Updating from MapLibre v4.4.1 to v4.6.0. See Maplibre changelogs for [v4.5.0](https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#450), [v4.5.1](https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#451), [v4.5.2](https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#452), and [v4.6.0](https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#460)
 - Fixed the elevation shift glitch happening with terrain animation after calling `.easeTo()` (https://github.com/maptiler/maptiler-sdk-js/pull/110)
+- The heatmap layer helper missed the `beforeId` option
 ### New Features
 - Updating from MapLibre v4.4.1 to v4.5.2, adding the following features. See Maplibre changelogs for for [v4.5.0](https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#450), [v4.5.1](https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#451), [v4.5.2](https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#452), and [v4.6.0](https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md#460)
 ### Others

diff --git a/src/helpers/vectorlayerhelpers.ts b/src/helpers/vectorlayerhelpers.ts
@@ -1329,30 +1329,33 @@ export function addHeatmap(
     });
   }
 
-  map.addLayer({
-    id: layerId,
-    type: "heatmap",
-    source: sourceId,
-    minzoom,
-    maxzoom,
-    paint: {
-      "heatmap-weight": heatmapWeight,
-
-      "heatmap-intensity":
-        typeof intensity === "number"
-          ? intensity
-          : (rampedOptionsToLayerPaintSpec(intensity) as PropertyValueSpecification<number>),
-
-      "heatmap-color": heatmapIntensityFromColorRamp(colorRamp),
-
-      "heatmap-radius": radiusHeatmap,
-
-      "heatmap-opacity":
-        typeof opacity === "number"
-          ? opacity
-          : (rampedOptionsToLayerPaintSpec(opacity) as PropertyValueSpecification<number>),
+  map.addLayer(
+    {
+      id: layerId,
+      type: "heatmap",
+      source: sourceId,
+      minzoom,
+      maxzoom,
+      paint: {
+        "heatmap-weight": heatmapWeight,
+
+        "heatmap-intensity":
+          typeof intensity === "number"
+            ? intensity
+            : (rampedOptionsToLayerPaintSpec(intensity) as PropertyValueSpecification<number>),
+
+        "heatmap-color": heatmapIntensityFromColorRamp(colorRamp),
+
+        "heatmap-radius": radiusHeatmap,
+
+        "heatmap-opacity":
+          typeof opacity === "number"
+            ? opacity
+            : (rampedOptionsToLayerPaintSpec(opacity) as PropertyValueSpecification<number>),
+      },
     },
-  });
+    options.beforeId,
+  );
 
   return returnedInfo;
 }