Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #585 and may address #1383.
I stepped down the code and found out, that the memory issue does not apply to the light build. After some debugging I found
tileserver-gl/src/serve_rendered.js
Line 1060 in a245126
and
tileserver-gl/src/serve_rendered.js
Line 1220 in a245126
I assumed that these are not found by the garbage collector because there is a reference somewhere, to I added an explicit cleanup function
clear
, which required the before inaccessibleserving
to handle therepo
.As a result I have no more increasing memory with reloading by SIGHUP.