Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SIGUP Memory Leak #1455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okimiko
Copy link
Contributor

@okimiko okimiko commented Jan 31, 2025

This addresses #585 and may address #1383.

I stepped down the code and found out, that the memory issue does not apply to the light build. After some debugging I found

const renderer = new mlgl.Map({

and
return new advancedPool.Pool({

I assumed that these are not found by the garbage collector because there is a reference somewhere, to I added an explicit cleanup function clear, which required the before inaccessible serving to handle the repo.

As a result I have no more increasing memory with reloading by SIGHUP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant