Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpunit #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pascalheidmann
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #16 (630cfd0) into master (63d391c) will decrease coverage by 0.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
- Coverage     59.00%   58.58%   -0.42%     
+ Complexity       40       37       -3     
============================================
  Files             3        3              
  Lines           100       99       -1     
============================================
- Hits             59       58       -1     
  Misses           41       41              
Impacted Files Coverage Δ
src/EnumMethodReflection.php 100.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@pascalheidmann
Copy link
Author

@marc-mabe can you have a look at this? :)

@marc-mabe
Copy link
Owner

Hi @pascalheidmann ,
Why do you remove supported PHP versions only to upgrade PHPunit?

@pascalheidmann
Copy link
Author

@marc-mabe these PHP versions are way beyond their EOL, and PHPUnit 9 therefore requires at least PHP 7.3 (also already EOL)

@marc-mabe
Copy link
Owner

Hi @pascalheidmann,
EOL PHP Versions means it's not supported by PHP anymore but there are distros having much longer (payed) support plans including PHP.
Anyway upgrading the minimum PHP Version requires some kind of benefit which I don't see here.
If you want to improve or simplify the tests which requires the new version I'm open for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants