feat: Simplify use_asset_cacher hook
#1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc2332
added
enhancement 🔥
marc2332
commented
Jan 1, 2025
crates/hooks/src/use_asset_cacher.rs
Outdated
| @@ -36,7 +40,7 @@ pub enum AssetAge { | |||
|
|
|||
| impl Default for AssetAge { | |||
| fn default() -> Self { | |||
| Self::Duration(Duration::from_secs(3600)) // 1h | |||
| Self::Duration(Duration::from_secs(10)) // 1h | |||
marc2332
commented
Jan 1, 2025
crates/hooks/Cargo.toml
Outdated
| @@ -41,6 +41,7 @@ nokhwa = { version = "0.10.7", features = ["input-native"], optional = true } | |||
| paste = "1.0.14" | |||
| bitflags = "2.4.1" | |||
| bytes = "1.5.0" | |||
| tracing.workspace = true | |||
There was a problem hiding this comment.
Suggested change
| tracing.workspace = true | |
| tracing = { workspace = true } |
marc2332
commented
Jan 1, 2025
examples/app_dog.rs
Outdated
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
========================================
Coverage 74.78% 74.79%
========================================
Files 219 219
Lines 25433 25576 +143
========================================
+ Hits 19020 19129 +109
- Misses 6413 6447 +34 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.