Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency astro to v5.0.8 [security] #984

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 14, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
astro (source) 5.0.5 -> 5.0.8 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-56159

Summary

A bug in the build process allows any unauthenticated user to read parts of the server source code.

Details

During build, along with client assets such as css and font files, the sourcemap files for the server code are moved to a publicly-accessible folder.
https://github.com/withastro/astro/blob/176fe9f113fd912f9b61e848b00bbcfecd6d5c2c/packages/astro/src/core/build/static-build.ts#L139

Any outside party can read them with an unauthorized HTTP GET request to the same server hosting the rest of the website.

While some server files are hashed, making their access obscure, the files corresponding to the file system router (those in src/pages) are predictably named. For example. the sourcemap file for src/pages/index.astro gets named dist/client/pages/index.astro.mjs.map.

PoC

Here is one example of an affected open-source website:
https://creatorsgarten.org/pages/index.astro.mjs.map

The file can be saved and opened using https://evanw.github.io/source-map-visualization/ to reconstruct the source code.

The above accurately mirrors the source code as seen in the repository: https://github.com/creatorsgarten/creatorsgarten.org/blob/main/src/pages/index.astro

The above was found as the 4th result (and the first one on Astro 5.0+) when making the following search query on GitHub.com (search results link):

path:astro.config.mjs @​sentry/astro

This vulnerability is the root cause of https://github.com/withastro/astro/issues/12703, which links to a simple stackblitz project demonstrating the vulnerability. Upon build, notice the contents of the dist/client (referred to as config.build.client in astro code) folder. All astro servers make the folder in question accessible to the public internet without any authentication. It contains .map files corresponding to the code that runs on the server.

Impact

All server-output (SSR) projects on Astro 5 versions v5.0.3 through v5.0.6 (inclusive), that have sourcemaps enabled, either directly or through an add-on such as sentry, are affected. The fix for server-output projects was released in [email protected].

Additionally, all static-output (SSG) projects built using Astro 4 versions 4.16.17 or older, or Astro 5 versions 5.0.7 or older, that have sourcemaps enabled are also affected. The fix for static-output projects was released in [email protected], and backported to Astro v4 in [email protected].

The immediate impact is limited to source code. Any secrets or environment variables are not exposed unless they are present verbatim in the source code.

There is no immediate loss of integrity within the the vulnerable server. However, it is possible to subsequently discover another vulnerability via the revealed source code .

There is no immediate impact to availability of the vulnerable server. However, the presence of an unsafe regular expression, for example, can quickly be exploited to subsequently compromise the availability.

  • Network attack vector.
  • Low attack complexity.
  • No privileges required.
  • No interaction required from an authorized user.
  • Scope is limited to first party. Although the source code of closed-source third-party software may also be exposed.

Remediation

The fix for server-output projects was released in [email protected], and the fix for static-output projects was released in [email protected] and backported to Astro v4 in [email protected]. Users are advised to update immediately if they are using sourcemaps or an integration that enables sourcemaps.


Release Notes

withastro/astro (astro)

v5.0.8

Compare Source

Patch Changes

v5.0.7

Compare Source

Patch Changes

v5.0.6

Compare Source

Patch Changes

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.15%. Comparing base (24c1797) to head (46655fa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #984   +/-   ##
=======================================
  Coverage   74.15%   74.15%           
=======================================
  Files         215      215           
  Lines       24685    24685           
=======================================
  Hits        18305    18305           
  Misses       6380     6380           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title fix(deps): update dependency astro to v4.16.1 [security] fix(deps): update dependency astro to v4.16.1 [security] - autoclosed Nov 18, 2024
@renovate renovate bot closed this Nov 18, 2024
@renovate renovate bot deleted the renovate/npm-astro-vulnerability branch November 18, 2024 01:02
@renovate renovate bot changed the title fix(deps): update dependency astro to v4.16.1 [security] - autoclosed fix(deps): update dependency astro to v4.16.1 [security] Nov 20, 2024
@renovate renovate bot reopened this Nov 20, 2024
@renovate renovate bot force-pushed the renovate/npm-astro-vulnerability branch from ce2c2c1 to d8a9f3c Compare November 20, 2024 16:58
@renovate renovate bot changed the title fix(deps): update dependency astro to v4.16.1 [security] fix(deps): update dependency astro to v4.16.1 [security] - autoclosed Dec 14, 2024
@renovate renovate bot closed this Dec 14, 2024
@renovate renovate bot changed the title fix(deps): update dependency astro to v4.16.1 [security] - autoclosed fix(deps): update dependency astro to v4.16.1 [security] Dec 18, 2024
@renovate renovate bot reopened this Dec 18, 2024
@renovate renovate bot force-pushed the renovate/npm-astro-vulnerability branch from e0729c5 to d8a9f3c Compare December 18, 2024 17:27
@renovate renovate bot changed the title fix(deps): update dependency astro to v4.16.1 [security] fix(deps): update dependency astro to v4.16.17 [security] Dec 18, 2024
@renovate renovate bot changed the title fix(deps): update dependency astro to v4.16.17 [security] fix(deps): update dependency astro to v4.16.17 [security] - autoclosed Dec 18, 2024
@renovate renovate bot closed this Dec 18, 2024
@renovate renovate bot changed the title fix(deps): update dependency astro to v4.16.17 [security] - autoclosed fix(deps): update dependency astro to v4.16.17 [security] Dec 19, 2024
@renovate renovate bot reopened this Dec 19, 2024
@renovate renovate bot changed the title fix(deps): update dependency astro to v4.16.17 [security] fix(deps): update dependency astro to v4.16.18 [security] Dec 19, 2024
@renovate renovate bot force-pushed the renovate/npm-astro-vulnerability branch from d8a9f3c to 46655fa Compare December 19, 2024 18:18
@renovate renovate bot changed the title fix(deps): update dependency astro to v4.16.18 [security] fix(deps): update dependency astro to v5.0.8 [security] Dec 19, 2024
@marc2332 marc2332 merged commit 59915b5 into main Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant