Prepare path escaping #38
Open
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses rfc3986 reserved characters, without /, because slashes in the
s3 object name have already been accounted for when the name was created.
(i.e. the end-to-end expectation is that they are used as namespace delimiters
when used in URLs).
This patch also escapes spaces with percent encoding.
More info on what is considered reserved:
rfc 3986 specifies these as reserved characters in a URL:
!*'();:@&=+$,/?#[]
of these, Amazon thinks these need to be escaped when it generates urls
from its web console:
';:@&=+$,?#[ ]
and Amazon thinks these DO NOT need to be escaped:
!*()
Amazon escapes spaces with +
Ruby's URI provides two regexes. What it considers to be reserved is an inexplicable
subset of rfc3986
URI::REGEXP::PATTERN::UNRESERVED
-_.!~*'()a-zA-Z\\d
URI::REGEXP::PATTERN::RESERVED
;/?:@&=+$,\\[\\]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a file on s3 has a URI reserved character in its name, it's possible for it to make its way into the URL.
Some browsers make a correct guess about dealing with this, and others don't. Depending on one's definition of correct. The point is, they will make different guesses, resulting in the timeout signature being incorrect in some cases.