Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app.ts #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update app.ts #33

wants to merge 1 commit into from

Conversation

tibor
Copy link
Contributor

@tibor tibor commented Nov 10, 2024

should work with #28

@marcomaroni-github
Copy link
Owner

I'm not sure about this change because there are cases where the video is actually inserted as a "link" and the import should not be skipped. As I wrote here unfortunately the documentation is not very clear and specific errors should be distinguished to evaluate whether to insert the "continue" at that point.

@tibor
Copy link
Contributor Author

tibor commented Nov 10, 2024

You mean a link to the video on twitter, right? I think that should be fine.

However, if the video is too long, there is no job id and thus the script runs into an error if we don’t continue at this point.

@marcomaroni-github
Copy link
Owner

You mean a link to the video on twitter, right? I think that should be fine.

No, it happened to me that if for some reason the same video was referenced by multiple tweets, when the first post is created on Bluesky the video is loaded, in the second one it is not and the loading job ends with a warining but it was still possible to create the second post with the job gone into "error". A very particular case that in fact we could ignore, I'm undecided.

However, if the video is too long, there is no job id and thus the script runs into an error if we don’t continue at this point.

The basic problem is that errors or non-blocking warning of that API are not documented so it is very complex to implement consistent error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants