Limit the number of attached databases to zero and enable defensive mode #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is perfect! Since I'm refactoring this code, I've copied it verbatim into #235, so I'll close this one and the code will appear once the refactor is done. Thank you for protecting ayb users! :) |
|
I forgot to close this myself :p |
marcua
added a commit
that referenced
this pull request
Dec 28, 2023
* A version that won't build * Uncomment * Newline * Newline * Compiles * No need for only temp * Compiles AND runs * Move toward nsjail * Make room for nsjail, but still as a noop * Bring in #234 * Works end-to-end (need to implement 'touch' for new DBs) * Create DB file in create_database * Move isolated runner into original crate as second binary, dynamically determine path to it * Remove hosted_db_runner * Move nsjail builder to scripts dir * fmt * tokio typo * New AybError variants * Code review part 1 * Update docs, remove binary, add nsjail build step * Testing docs and fmt * Fix build command * nsjail requirements * More nsjail requirements * Docs cleanup * Clippy and code review * Warn if not fully isolated * Clean up for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #41.
This PR limits the number maximum attached databases to zero (none) and enables defensive mode to prevent deliberate corruption of the database.
Refs:
https://www.sqlite.org/c3ref/c_dbconfig_defensive.html
https://www.sqlite.org/lang_attach.html
https://www.sqlite.org/c3ref/c_limit_attached.html#sqlitelimitattached
https://www.sqlite.org/c3ref/limit.html