Add random IBAN generation #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
marcwrobel
force-pushed
the
153-add-iban-generation
branch
2 times, most recently
from
1d451fa to
e2680c9
Compare
marcwrobel
force-pushed
the
153-add-iban-generation
branch
4 times, most recently
from
2ba8a45 to
2fcd412
Compare
|
@aSemy, the initial implementation for random IBAN generation is ready. Could you have a look at the |
marcwrobel
force-pushed
the
153-add-iban-generation
branch
from
2fcd412 to
73f1ef0
Compare
marcwrobel
changed the title
|
@marcwrobel Thanks! I'll take a look. |
aSemy
reviewed
Oct 20, 2022
aSemy
reviewed
Oct 20, 2022
|
You might like to look at my PR for iban4j that does the same thing. The code is different, but the tests might be useful. arturmkrtchyan/iban4j#93 |
aSemy
reviewed
Oct 20, 2022
aSemy
reviewed
Oct 20, 2022
Thank you for your time @aSemy ! |
The BbanStructure has been made public as part of this commit but the isBbanValid method is still package private. We do not want to expose it for the time being : users are expected to use the Iban class instead.
marcwrobel
force-pushed
the
153-add-iban-generation
branch
from
73f1ef0 to
b8b5630
Compare
|
A pleasure! Thanks for taking the time to improve the library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BbanStructure has been made public as part of this commit but the isBbanValid method is still package private. We do not want to expose it for the time being : users are expected to use the Iban class instead.