Skip to content

Commit

Permalink
Merge pull request Expensify#35902 from ruben-rebelo/ts-migration/e2e…
Browse files Browse the repository at this point in the history
…-config.local

[No QA][TS migration] Migrate config.local from e2e to Typescript
  • Loading branch information
lakchote authored Feb 19, 2024
2 parents 0f9c4fa + c29b7e0 commit d2259b5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
4 changes: 2 additions & 2 deletions tests/e2e/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ Ideally you want to run these tests on your branch before you want to merge your

The tests can be run with the following CLI options:

- `--config`: Extend/Overwrite the default config with your values, e.g. `--config config.local.js`
- `--config`: Extend/Overwrite the default config with your values, e.g. `--config config.local.ts`
- `--includes`: Expects a string/regexp to filter the tests to run, e.g. `--includes "login|signup"`
- `--skipInstallDeps`: Skips the `npm install` step, useful during development
- `--development`: Applies some default configurations:
- Sets the config to `config.local.js`, which executes the tests with fewer iterations
- Sets the config to `config.local.ts`, which executes the tests with fewer iterations
- Runs the tests only on the current branch
- `--buildMode`: There are three build modes, the default is `full`:
1. **full**: rebuilds the full native app in (e2e) release mode
Expand Down
7 changes: 5 additions & 2 deletions tests/e2e/config.local.js → tests/e2e/config.local.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
module.exports = {
type Config = Record<string, string | number>;

const config: Config = {
MAIN_APP_PACKAGE: 'com.expensify.chat.e2e',
DELTA_APP_PACKAGE: 'com.expensify.chat.e2edelta',
MAIN_APP_PATH: './android/app/build/outputs/apk/e2e/release/app-e2e-release.apk',
DELTA_APP_PATH: './android/app/build/outputs/apk/e2edelta/release/app-e2edelta-release.apk',

BOOT_COOL_DOWN: 1 * 1000,
RUNS: 8,
};

export default config;
2 changes: 1 addition & 1 deletion tests/e2e/testRunner.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ let buildMode = 'full';
// When we are in dev mode we want to apply certain default params and configs
const isDevMode = args.includes('--development');
if (isDevMode) {
setConfigPath('config.local.js');
setConfigPath('config.local.ts');
buildMode = 'js-only';
}

Expand Down

0 comments on commit d2259b5

Please sign in to comment.