-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emktg 502/prestashop validator #2
Open
margud
wants to merge
1,131
commits into
master
Choose a base branch
from
EMKTG-502/prestashop-validator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set default values in Config class and avoid using a .env.dist file
Rename app div to avoid potential conflicts with other modules using VueJS application
added onboard exception catch
added php side logic for ps_accounts upgrade
feat (segment) : add event on catalog page
Run composer upgrade and fix tests
added app id in sentry
Update wording
Remove one get of $_ENV
context doesnt exist
Update translations
added new segment params
Bring back PS Account component with install button
Use shop ID as segment identifier instead of the domain
…ebook is uninstalled
improved sentry error for guzzle errors
Backport of 1.4.x on master branch
Check upgrade folder with phpstan
Disable error handlers
Merge changes of v1.4.5 in master
Validator Results |
4 similar comments
Validator Results |
Validator Results |
Validator Results |
Validator Results |
98017a7
to
f156bab
Compare
f156bab
to
26e71e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.