Expose API url variables for ghostnet & mainnet #5
Conversation
quentin-burg
force-pushed
the
staging
branch
from
acba3e5
to
ee914fd
Compare
| sed -i 's|KT1Re88VMEJ7TLHTkXSHQYZQTD3MP3k7j6Ar|KT199yuNkHQKpy331A6fvWJtQ1uan9uya2jx|g' ./examples/nft/.env | ||
| sed -i 's|KT1Rp1rgfwS25XrWU6fUnR8cw6KMZBhDvXdq|KT1MLMXwFEMcfByGbGcQ9ow3nsrQCkLbcRAu|g' ./examples/nft/.env | ||
| sed -i 's|KT1Re88VMEJ7TLHTkXSHQYZQTD3MP3k7j6Ar|KT1CvtrTV7snJSxdnQqhSqh47tyVYhm4ACGB|g' ./examples/nft/.env | ||
| sed -i 's|KT1Rp1rgfwS25XrWU6fUnR8cw6KMZBhDvXdq|KT1K9X6QpuTWFX4S5ieDGTUdjAHQtiFRH5op|g' ./examples/nft/.env |
There was a problem hiding this comment.
I'm not sure why you're not changing the file directly? Is it because we're using a different account for the gas station on Ghostnet and Staging? I'm not sure it's worth it; and even then, we can change the contract to allow several admins.
There was a problem hiding this comment.
Or we could just originate a single contract that can have two admins, see aguillon/permit-cameligo#3
There was a problem hiding this comment.
Yes it's because the contract has only one admin but we can deploy the contract with several admin and just remove this part after.
index.ts
Outdated
| export const GAS_STATION_PUBLIC_API_GHOSTNET = | ||
| "https://ghostnet.gas-station-api.marigold.dev/operation"; | ||
| export const GAS_STATION_PUBLIC_API_MAINNET = | ||
| "https://gas-station-api.marigold.dev/operation"; | ||
|
|
There was a problem hiding this comment.
We should remove the trailing /operation and add it in postOperations.
index.ts
Outdated
| @@ -62,6 +72,8 @@ export class GasStation { | |||
| } | |||
| } | |||
|
|
|||
| const g = new GasStation(); | |||
New permit contract with multiple admins
for a more pleasing user experience!
Minor change in the interface of examples/nft.
Minting and stashing UX: add some visual feedback to the corresponding buttons.
|
Rebasing all of this in order not to introduce a merge commit in the history |
And update Gas Station class constructor to accept empty parameter and add Ghostnet api URL per default