Added live example for 'Adding Regions' doc #3561
Conversation
Add live example for 'Defining the Application Region'
CharlyJazz
changed the title
| @@ -233,6 +235,8 @@ myView.addRegions({ | |||
| }); | |||
| ``` | |||
|
|
|||
| [Live example](http://jsfiddle.net/charlyjazz/gze5ykov/49/) | |||
There was a problem hiding this comment.
Does this need to be switched out for a marionettejs account URL?
There was a problem hiding this comment.
I've forked at http://jsfiddle.net/marionettejs/kjvzdyd6/ to use marionettejs account
|
@scott-w we'll have to swap out the link at merge. As far as the router is concerned since |
|
Unsubscribe me to this thread please…
Best Regards,
NW Computing Office Manager
NW Computing Office Manager
[cid:logo_horizontal_inverted_60cb0183-c447-43a8-a150-00e8baf7caa5.png]
Level 12, 459 Little Collins St, Melbourne VIC 3000
Level 15, 1 Castlereagh St, Sydney NSW 2000
Level 22, 127 Creek Street, Brisbane QLD 4000
Level 13, 50 Cavill Ave, Surfers Paradise QLD 4217
P 1300 484 529
E [email protected]<mailto:[email protected]> | W nwcomputing.com.au<http://nwcomputing.com.au>
[cid:fb-icon_6f360223-2e9d-47de-95f8-16d578342f26.gif]<http://facebook.com/nwcomputing> [cid:tw-icon_944dcbc2-146a-40b6-ae6c-988cc5bf9473.gif] <http://twitter.com/nwcomputing> [cid:in-icon_17ac0afa-8c93-45da-a314-230ae0c839e7.gif] <https://www.linkedin.com/company/nw-computing>
[cid:MSPMentor_20b72b30-fb78-4ed4-9a32-b6f514990acf.png]
From: Paul Falgout [mailto:[email protected]]
Sent: Tuesday, 5 December 2017 12:33 AM
To: marionettejs/backbone.marionette <[email protected]>
Cc: Subscribed <[email protected]>
Subject: Re: [marionettejs/backbone.marionette] Added live example for 'Adding Regions' doc (#3561)
@scott-w<https://github.com/scott-w> we'll have to swap out the link at merge.
As far as the router is concerned since AppRouter is being made an external component this is currently the easiest way to keep this from needing to be updated with v4. We certainly could change it to use the other lib at that time, but it also doesn't seem necessary.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#3561 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AB6PdoeTzhGi98Ei1pE_slGr12pw2o9hks5s8_RygaJpZM4Qvf0_>.
|
|
@cusial to my knowledge this is something you need to do yourself. There should be an unsubscribe button on this PR and you can unwatch the library at the top of github. There's also an unsubscribe link in the email. But we don't have the ability to do this for you. |
There was a problem hiding this comment.
@paulfalgout Fair enough, I'm happy with this as-is. If I get chance tomorrow and you're happy to 👍 it I can merge and fix the link tomorrow.
|
Friends missing something to do here? |
|
@CharlyJazz after updating the last jsfiddle link i think is good to go |
|
I'll get this in after #3561 lands |
|
Hahaha what? |
|
It's been a long time since I have a beard 🎉 |
|
Added to |
Proposed changes
Link to the issue: #3209