Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a few new E2E files that were more thoroughly anonymized by Heidelberg's software and made a few changes so that these files could be read through. This includes adding a try/except for
e2e_binary.chunk_structure.parse(raw)
and better handling of now potentially missing patient metadata.For context, the errors that were observed were mostly
with
raw
beingb''
(which could be handled more specifically by looking atlen(raw)
before parsing, if that's preferred)and a few instances of
'ascii' codec can't decode byte 0xc7 in position 0: ordinal not in range(128)
withraw
asb'\xc7\xd7\xbe\x00\x00\x00\x003\xc4\x00\x00\x00\x00\xbf\xbd\xad\xc1\x00\x00}\xc4\x00\x00\x00\x00\x00\x00\x9f\xc5\x8d\xc6\xac\xc1\x00\x00%\xc4\xba\xc0\r\xc3\x00\x00\x00\x00\x00\x00\xd7\xc4\x83\xc1\x00\x00\x06\xb1?\xc3)\xc4\x00'
(again, might be a more graceful way of handling this, but for now skipping is simpler and from the files I've tested on still output as expected).(I'd been hoping to get my hands on some of these new-anonymization files!)