Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fx #251

Merged
merged 3 commits into from
Mar 14, 2024
Merged

feat: add fx #251

merged 3 commits into from
Mar 14, 2024

Conversation

ppeeou
Copy link
Member

@ppeeou ppeeou commented Mar 9, 2024

Fixes #250

Supports method chaining only for commonly used functions.

  • add function fx
  • add test case
    • type
    • logic
  • guide

@ppeeou ppeeou self-assigned this Mar 9, 2024
@ppeeou ppeeou requested a review from shine1594 as a code owner March 9, 2024 13:33
@ppeeou ppeeou changed the title feat: add fx feat: add fx Mar 9, 2024
@ppeeou ppeeou marked this pull request as draft March 9, 2024 14:15
@ppeeou ppeeou force-pushed the feat/fx branch 2 times, most recently from 3cb2249 to 6ffc881 Compare March 9, 2024 15:26
@ppeeou ppeeou marked this pull request as ready for review March 9, 2024 15:27
@ppeeou ppeeou force-pushed the feat/fx branch 5 times, most recently from 8c3c798 to d0915ed Compare March 10, 2024 03:31
Copy link
Collaborator

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow

import takeWhile from "./takeWhile";
import toAsync from "./toAsync";

class FxAsyncIterable<A> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class seems to act like a Factor. Can you explain this philosophy in detail?

Copy link
Collaborator

@hg-pyun hg-pyun Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also a need to use it in a method chaining, so I decided to provide it

@ppeeou ppeeou merged commit 53d495c into main Mar 14, 2024
1 check passed
@ppeeou ppeeou deleted the feat/fx branch March 14, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support fluent Interface
2 participants