Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropUntil.ts example #272

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: dropUntil.ts example #272

merged 1 commit into from
Apr 26, 2024

Conversation

hg-pyun
Copy link
Collaborator

@hg-pyun hg-pyun commented Apr 25, 2024

As-Is

// The example answer is 3, 4, 5, but the correct answer is 2, 3, 4, 5, 1, 2 
const iter = dropUntil((a) => a < 3, [1, 2, 3, 4, 5, 1, 2])

To-Be

I think it is a mistake copying and pasting dropWhile. Considering the context, I think it's the right way to change it as follows.

const iter = dropUntil((a) => a > 3, [1, 2, 3, 4, 5, 1, 2]);

@hg-pyun hg-pyun self-assigned this Apr 25, 2024
Copy link
Member

@ppeeou ppeeou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ppeeou ppeeou merged commit 8a2bff9 into main Apr 26, 2024
1 check passed
@ppeeou ppeeou deleted the fix/dropUntil-docs branch April 26, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants