-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-forcefield-specific citations to the root of the data directory #655
Conversation
This is particularly useful for /code/ that needs citing, such as MDTraj, and vermouth
…eck FFs of incoming molecules
I'm not going to meet the patch test coverage; it's mostly because there's no tests for the Quote processor (and I don't care about that), and there's no tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just one query about how mdtraj citations are now treated, because I think this now has the citation written regardless of whether it was used?
This is particularly useful for code that needs citing, such as MDTraj, and vermouth.
The vermouth citation gets formatted as
Things got a bit more messy because of Molecules and Systems without forcefield (or,
force_field=None
), so I also did something sane with the defaults there.