Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect angles in helices when adjacent to prolines (2nd try) #675

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

mnmelo
Copy link
Contributor

@mnmelo mnmelo commented Mar 10, 2025

Re-submitting this PR because its original incarnation (#673) was mistakenly closed too early. See the discussion there.

The current implementation weakens helical BB-BB-BB angles whenever a Pro is present, which makes sense.

The helical dihedrals, however, are never switched off (shouldn't they be?). Helix BB-BB-BB angles centered on Pro are, therefore, protected by type 10 angles from reaching 180 deg.

Angles involving adjacent residues, however, are problematic because they are also weakened, but not protected by type 10 potentials. This PR fixes that.

Fixes #674.

mnmelo added 3 commits March 5, 2025 19:26
The current implementation weakens helical BB-BB-BB angles whenever a Pro is present, which makes sense.

The helical dihedrals, however, are never switched off (shouldn't they be?). Helix BB-BB-BB angles centered on Pro are, therefore, protected by type 10 angles from reaching 180 deg.

Angles involving adjacent residues, however, are problematic because they are also weakened, but not protected by type 10 potentials. This PR fixes that.
@mnmelo
Copy link
Contributor Author

mnmelo commented Mar 10, 2025

Should be good to go, @pckroon.

Copy link
Member

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! Looks good to me!

@pckroon pckroon merged commit 41aabed into marrink-lab:master Mar 12, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pro-adjacent residues in helices have weak, unprotected angles.
2 participants