Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert SummernoteConfig toolbarOptions code, Array.asList is unmodifiable #1158

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Revert SummernoteConfig toolbarOptions code, Array.asList is unmodifiable #1158

merged 1 commit into from
Oct 17, 2024

Conversation

r1gm
Copy link
Contributor

@r1gm r1gm commented Oct 17, 2024 •
edited
Loading

Fixes #1156

@r1gm
revert problematic code to the good old code, Arrays.asList is unmodi…
b1bc8c1 
…fiable, toolbarOptions need modifiable list.
@r1gm r1gm mentioned this pull request Oct 17, 2024
Closed
@martin-g martin-g merged commit d7e68d6 into martin-g:wicket-10.x-bootstrap-5.x Oct 17, 2024
2 checks passed
@martin-g
Copy link
Owner

Thank you, @r1gm !

martin-g pushed a commit that referenced this pull request Oct 17, 2024
@r1gm @martin-g
revert problematic code to the good old code, Arrays.asList is unmodi…
59122d8 
…fiable, toolbarOptions need modifiable list. (#1158)

(cherry picked from commit d7e68d6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-g martin-g martin-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

using SummernoteEditor causing java.lang.UnsupportedOperationException: remove
2 participants
@r1gm @martin-g