Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add linting & testing #22

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci: add linting & testing #22

wants to merge 1 commit into from

Conversation

Nytelife26
Copy link
Contributor

TODO:

  • Add tests
  • Discuss whether or not we need to add coverage reports (e.g. via codecov)

@Nytelife26 Nytelife26 mentioned this pull request Jun 24, 2024
Open
2 tasks
gaby
gaby reviewed Jul 13, 2024
View reviewed changes
.github/workflows/ci-lint-test.yml
strategy:
matrix:
python: ["3.8", "3.9", "3.10", "3.11", "3.12", "pypy3.9", "pypy3.10"]
os: [ubuntu-latest, macos-12, windows-latest]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use macos-latest here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last time i tried this, macos latest uses a different architecture (ARM), which didn't have older python versions at the time. unless this has changed, that will not be possible.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, seems that changed recently. macos-latest used to point to macos-13, now it points to 14 which uses M1 cpu's.

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

So in theory you can use macos-13, instead of 12

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's especially important now that macos-12 is EOL. macos-13 has another year of support, so i'll resolve this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaby gaby gaby left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nytelife26 @gaby