Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saves #21

Merged
merged 4 commits into from
Jul 30, 2015
Merged

Saves #21

merged 4 commits into from
Jul 30, 2015

Conversation

martindale
Copy link
Owner

This add support for saving a post; or adding it to your "bookmark" list.

martindale
martindale reviewed Jul 29, 2015
View reviewed changes
views/person.jade
code saves.length: #{saves.length}
.ui.cards
for save in saves
+PostView(save, 20)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This view will fail, as save._author does not get populated by default. We should look to implement this in martindale/maki#87.

@martindale
Copy link
Owner Author

Some additional thoughts, seeking commentary – perhaps we add a new hydrate option per attribute, which specifies the fields that should be "populated" when the resource is included as a requirement from some other resource. This offers granularity (populate vs. hydrate), but isn't the most transparent when it comes to clarity of intent.

I'm sure there is a better way to consolidate these options and simultaneously provide the granularity of control an application developer would like, but I haven't thought deeply enough about this particular issue yet.

@martindale martindale changed the title WIP: Saves Saves Jul 30, 2015
@martindale
Copy link
Owner Author

I've implemented a much cleaner solution upstream – martindale/maki#93 – and updated these changes to utilize the new features.

martindale added a commit that referenced this pull request Jul 30, 2015
@martindale
Merge pull request #21 from martindale/saves
272dfe9 
Saves
@martindale martindale merged commit 272dfe9 into alpha Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martindale