Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very simple jitter buffer #54

Merged
merged 6 commits into from
Mar 27, 2020

Conversation

trevorirwin
Copy link
Contributor

This PR implements a very simple jitter buffer by delaying the process of reading audio out of the AudioDecodingBuffer and substituting silence when new audio data from the network is unavailable. See #52 for more.

Copy link
Owner

@martindevans martindevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that one minor thing this looks good :)

MumbleSharp/Audio/AudioDecodingBuffer.cs Outdated Show resolved Hide resolved
@martindevans martindevans merged commit 606bcb9 into martindevans:master Mar 27, 2020
@martindevans
Copy link
Owner

Thanks @trevorirwin :)

@Meetsch Meetsch linked an issue Jun 9, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jitteryness simple fix
2 participants