Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using wx to prevent concurrent writes to the cache #6

Merged
merged 1 commit into from
Feb 17, 2018

Conversation

martinheidegger
Copy link
Owner

@loklaan kindly provided #5 as an attempt to prevent to deal with the issue presented in #3. When reviewing it and writing a test I thought that using wx as a file mode might be more efficient - as it works even though not the same node instance is trying to access the same cache - and results in less lines of code.

@coveralls
Copy link

coveralls commented Feb 16, 2018

Coverage Status

Coverage remained the same at 98.039% when pulling 671b81f on fix-write-lock-safety2 into 4df22ef on master.

@loklaan
Copy link

loklaan commented Feb 17, 2018

Oh yeah, this totally makes sense! I'll close #5

Thanks for jumping on this so quick, and successfully making a test too

@martinheidegger martinheidegger merged commit db747dc into master Feb 17, 2018
@martinheidegger martinheidegger deleted the fix-write-lock-safety2 branch February 17, 2018 02:42
@martinheidegger
Copy link
Owner Author

Published as 1.2.2

@loklaan
Copy link

loklaan commented Feb 20, 2018

Yaaas, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants