Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(TX2 Fix) Updating gtop to use command-line arguments #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zlacelle
Copy link

to specify the board type, not guess based on fields out of tegrastats. Added EMC plot.

…, not guess based on fields out of tegrastats. Added EMC plot.
@martinkersner
Copy link
Owner

Hi @zlacelle!

Awesome work! Could you check if it is working on TX2?

Cheers,
Martin

@zlacelle
Copy link
Author

@confusedrobot if you can send me a few lines of tegrastats output, I will run it through the code today and make sure it's good. I'll try to add in some sanity checks as well.

There are a few other changes I made in my repo which I'll also push, once I clean them up.

@confusedrobot
Copy link

confusedrobot commented Jul 29, 2018

Here's my tegrastats output:
tegrastats.txt

@zlacelle

@confusedrobot
Copy link

@zlacelle let me know if there's anything else I can provide to help debug this.

@zlacelle
Copy link
Author

@confusedrobot Just didn't have time today, I'll hopefully have some time to take a look tomorrow.

@gustavz
Copy link

gustavz commented Aug 1, 2018

Do you get it working till tomorrow? Would be super awesome and important for me!

@zlacelle
Copy link
Author

zlacelle commented Aug 1, 2018

I created a new pull request here: #6

I switched to what should be a more robust parsing method. @confusedrobot I checked your tegrastats output, and it matches mine, so it should work.

If it doesn't work, compile with debug flags and send a core dump.

@gustavz If it doesn't work for you, send me your tegrastats output. Right now, the only testing I can do is on my TX2 running JetPack 3.2

@gustavz
Copy link

gustavz commented Aug 2, 2018

@zlacelle It works!!
Thank you!

But would it be possible that the tool averages the usage over a range of 30 secs or something?

@confusedrobot
Copy link

@zlacelle sorry it took awhile to respond, I am going to try the new fix now.

@martinkersner
Copy link
Owner

Hello @confusedrobot, @gustavz and @zlacelle !

I am planning to add test suite for supported devices so new pull requests can be tested against it. For this I would need an example output from tegrastats. Could you provide example output for any device you have?

Thank you,
Martin

@zlacelle
Copy link
Author

@martinkersner Will do. I'll try to get it from a Xavier and a TX2, but might take a few days.

@martinkersner
Copy link
Owner

@zlacelle Great! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants