Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Update Nix dependencies #231

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 2, 2024

Fixes #230

@martinpitt
Copy link
Owner

ooh, thanks @jtojnar ! Now it fails with udevadm: not found, but I suppose that's just "more of the same", so apparently systemdMinimal is not sufficient. Is there a separate udev?

git belongs to dependencies executable on build platform.
This is now enforced with strictDeps:
NixOS/nixpkgs@5876256

libpcap has already been added downstream:
NixOS/nixpkgs@a25fb7a

udevadm needs to be added to native inputs since it is expected by tests:
NixOS/nixpkgs@ded8c86
@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 2, 2024

Oh, I forgot that we removed the systemdMinimal in NixOS/nixpkgs#283252. Added that to the derivation.

Copy link
Owner

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jtojnar!

@martinpitt martinpitt merged commit a2eaf83 into martinpitt:main Mar 3, 2024
26 checks passed
@jtojnar jtojnar deleted the nix-deps-update branch March 3, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nix test is failing
2 participants