Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer version of lz4 with simpler build #274

Closed
wants to merge 1 commit into from
Closed

Prefer version of lz4 with simpler build #274

wants to merge 1 commit into from

Conversation

lucafavatella
Copy link

... thanks to rebar3 pc plugin rather than custom makefile.

I also requested upstream when a new tag will be released though I am not sure whether and when that will happen.


Attempting to compile locally project including this as a dependency, I got error hence this PR.

cc .../_build/default/lib/lz4/c_src/lz4hc.o .../_build/default/lib/lz4/c_src/lz4_nif.o .../_build/default/lib/lz4/c_src/lz4.o -L /Users/.../homebrew/opt/libsodium/lib -shared -L /Users/.../kerl/installations/OTP-20.3.8.20/lib/erl_interface-3.10.2.1/lib -lerl_interface -lei -o .../_build/default/lib/lz4/c_src/../priv/lz4.so
Undefined symbols for architecture x86_64:
  "_enif_alloc_binary", referenced from:
      _nif_compress in lz4_nif.o
      _nif_uncompress in lz4_nif.o

... thanks to rebar3 pc plugin rather than custom makefile.
@lucafavatella
Copy link
Author

I started running the tests (./rebar3 as test do cover --reset, eunit --cover, ct --cover, cover --verbose) though I had to abort that for now as it is taking a while. eunit tests passed, ct tests were passing when I interrupted them:

%%% appdefined_SUITE: .
%%% basic_SUITE: ....

I may be able to complete running the tests in the following days.

@lucafavatella
Copy link
Author

I noticed some issues on Windows, let me test this more.

@lucafavatella lucafavatella deleted the lz4-build branch April 1, 2019 18:14
@lucafavatella lucafavatella restored the lz4-build branch April 1, 2019 18:14
@lucafavatella lucafavatella deleted the lz4-build branch April 1, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant