Skip to content

Commit

Permalink
Merge pull request #443 from MikeBishop/why_email
Browse files Browse the repository at this point in the history 
Fix variable reference
  • Loading branch information
@martinthomson
martinthomson authored Aug 26, 2024
2 parents 915002b + 48d6e1f commit 329c20b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion get-email.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ draft="$2"
for k in taggeremail committeremail authoremail; do
tagger="$(git tag --list --format '%('"$k"')' "$tag" | sed -e 's/^<//;s/>$//')"
ghuser="${tagger%@users.noreply.github.com}"
if [ "$ghuser" = "$email" ]; then
if [ "$ghuser" = "$tagger" ]; then
emailok "git $k" "$tagger"
elif [ -n "$GITHUB_API_TOKEN" ]; then
script="import json,sys
Expand Down

3 comments on commit 329c20b

@pmeenan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance this broke the publication to datatracker flow?

I'm getting a 400 error from datatracker from the github actuin in the http-extensions repository that started today and the logs are showing {"error": "No such user: [email protected]"}.

@martinthomson
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmeenan sorry about that. GitHub does all sorts of things to tags. I think that I've managed to push a fix, but I've a lean time budget. If you try again and it fails, let me know.

@pmeenan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinthomson thanks. That fixed it.

Please sign in to comment.