Silence warning on first build #458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a draft is built for the first time, it always prints this error log: ``` Makefile:2: lib/main.mk: No such file or directory ``` Switching `include` to `-include` will silence the error, since it is always expected on first launch.
| @@ -1,5 +1,5 @@ | |||
| LIBDIR := lib | |||
| include $(LIBDIR)/main.mk | |||
There was a problem hiding this comment.
This isn't that simple, sadly.
I do like this change, but I'll need to tweak update.mk to match. It's a bit involved, sadly.
There was a problem hiding this comment.
A tragedy in 3 acts
- "oh how hard could it be?"
- checks update.mk
- slowly backs away from keyboard
There was a problem hiding this comment.
😁 Leave it with me. I've got a lot of work right now, but I know how to drive that.
There was a problem hiding this comment.
Thanks! This is incredibly low impact and priority so no rush :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a draft is built for the first time, it always prints this error log:
Switching
includeto-includewill silence the error, since it is always expected on first launch.