Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Apptainer images for comprl and comprl-web-reflex + some fixes #144

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

luator
Copy link
Member

@luator luator commented Jan 8, 2025

Provide Apptainer images, so we can run the comprl server and comprl-web-reflex in containers.

Also fixes of some issues that were made apparent by this:

  • Add requirements.txt for comprl-hockey-game
  • Move comprl source into a src/ subfolder, so installation auto-detects sub-packages.

luator added 5 commits January 8, 2025 14:33
I forgot to add this previously...
This should allow setuptools to automatically detect the package and all
sub-packages.

With the previous layout, sub-packages were not added automatically.
@luator luator changed the title comprl-hockey-game: Add requirements.txt Provide Apptainer images for comprl and comprl-web-reflex + some fixes Jan 13, 2025
@luator
Copy link
Member Author

luator commented Jan 13, 2025

comprl-web-reflex code wasn't touched in this PR, so ignore the corresponding mypy failure (to be fixed separately).

@luator luator merged commit 8a27d5a into main Jan 13, 2025
8 of 9 checks passed
@luator luator deleted the fkloss/hockey-game-req branch January 13, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant