Improve logging and monitoring #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
luator
commented
Jan 27, 2025
luator
commented
- Change logging format to include timestamp
- Use different logger names for different modules
- Store username in IPlayer, so it is more easily available for logging
- Periodically write information about connected players, games and matchmaking to a file for monitoring
- Add timestamp in log messages - Use separate loggers with specific names in different components - Move information like player IDs to the end in a easy parsable format (in case we ever want to do some parsing of the logs)
It's not really needed, but adding it there makes it more easily accessible for logging.
The information included in the file are - currently connected players - currently running games - the matchmaking queue - matchmaking scores With this, it is possible to quickly check what is currently going on without the need to add some extra interface to the server (which would likely the nicer but more complicated approach). I recommend using a file in `/dev/shm` for this to avoid unnecessary IO operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.