Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add actions-languageserver lsp #2378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add actions-languageserver lsp #2378

wants to merge 1 commit into from

Conversation

pbnj
Copy link
Contributor

@pbnj pbnj commented Aug 7, 2023

Closes #2377

@williambotman williambotman requested a review from a team August 7, 2023 18:21
@pbnj
Copy link
Contributor Author

pbnj commented Aug 7, 2023

Actually, hold off on this. The npm package @actions/languageserver does not provide a binary, but instead provides TypeScript types and compiled ECMAScript modules.

@williamboman
Copy link
Member

Alright, feel free to ping me again when it's ready 👍

@fredrikaverpil
Copy link
Contributor

@pbnj this would be a great to have. What was the blocker here?

@pbnj
Copy link
Contributor Author

pbnj commented Oct 6, 2023 •
edited
Loading

@fredrikaverpil - This is the blocker: actions/languageservices#56

The npm package is just an lsp library, not an executable lsp server.

@franklouwers
Copy link

as they don't seem to be very responsive at the github side, is there a way to wrap this in an executable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Actions Language Server
4 participants
@pbnj @williamboman @fredrikaverpil @franklouwers