fix: error with order by test #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: bump dependencies chore: update some js-doc chore: update tsconfig settings chore: lots of prettier changes due to prettier v3 default change
massfords
commented
Oct 27, 2024
massfords
commented
Oct 27, 2024
massfords
commented
Oct 27, 2024
massfords
commented
Oct 27, 2024
massfords
commented
Oct 27, 2024
massfords
commented
Oct 27, 2024
massfords
commented
Oct 27, 2024
massfords
commented
Oct 27, 2024
massfords
commented
Oct 27, 2024
massfords
commented
Oct 27, 2024
massfords
commented
Oct 27, 2024
massfords
commented
Oct 27, 2024
deadratfink
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Hi, looks all fine, can be merged.
Eslint 9 provides a migration target to adapt to new version. I tried that as well, but noticed that it had a bigger impact with some rule changes and code formattings and would push it to a later story. If you like, I also can do that maybe in the next days and prepare a PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: bump dependencies
chore: update some js-doc
chore: update tsconfig settings
chore: lots of prettier changes due to prettier v3 default change