Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Active Mode): enable Critical Hit text for Rams #1700

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msprijatelj
Copy link
Contributor

Description

This change borrows some Critical Hit decorators from _WeaponAttack.vue to indicate when a Ram is a critical hit, since the Critical Hit matters in some scenarios.

I'm not super familiar with Vuetify styling, otherwise the results would be a bit more appealing. If you have any advice on how to improve the styling, please let me know and I'll make the proper modifications.

Issue Number

Closes #1681

Type of change

  • Bug fix (non-breaking change which fixes an issue)

This change borrows some Critical Hit decorators from `_WeaponAttack.vue` to indicate when a Ram is
a critical hit.

Closes massif-press#1681
@msprijatelj msprijatelj self-assigned this Oct 1, 2021
@msprijatelj msprijatelj marked this pull request as draft October 8, 2021 03:40
@msprijatelj
Copy link
Contributor Author

Converting this to draft for now. Ideally would like some feedback before this one gets merged (if at all), and I’m not feeling great about the current execution.

@TranslucentSabre
Copy link
Contributor

Would you be able to post screenshots of what this looks like both without and with a crit roll, please?

@msprijatelj
Copy link
Contributor Author

Added the same "CRITICAL" text from Skirmish under a critical attack roll:
image

Ram results with a Critical Hit:
image

Ram results with a Normal Hit:
image

Ram results on a failure:
image

@msprijatelj
Copy link
Contributor Author

Compared to Skirmish Critical Hit:
image

And Skirmish Normal Hit:
image

@msprijatelj
Copy link
Contributor Author

msprijatelj commented Oct 12, 2021

Realizing that the "Hit" box color is different for a critical hit instead of a normal hit when using Skirmish; I'll have to include that behavior for Ram if I continue with this PR.

@TranslucentSabre
Copy link
Contributor

I like this change. It's niche, but I can see it's usefulness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Ram action not showing critical hit on result of 20+
2 participants