Make --vmaf parameter work independently again #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rustfmt please |
damster101
force-pushed
the
master
branch
2 times, most recently
from
4d79448
to
78709f4
Compare
Better now? But someone really should run rustfmt on the entire project, I had to "fix" all those indentations to match the rest of the project... |
|
That's weird, it should already be correct for the rest of the project. The CI validates it on each MR. |
It seems rustfmt behaves very differently when I run it on the whole context.rs file compared to just the isolated function. I did the latter and got a ton of changes everywhere, especially lots of two space indentations were increased in size to four spaces. |
shssoichiro
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #824