Add grapher branch view #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The intention of this class is to allow creating a GrapherView for Spot+Link and BranchSpot+BranchLink in the future and at the same time avoid code duplication as much as possible * Methods that will be needed for both type of views, such as menu generation, color registration, creation of dataframe and datapanel can be found in this class
* Similarly to the existing Grapher that can show features on Spot level, the new window can be used to show features on the branch spot level
* Reflects the purpose of these variables in the grapher screen transform handler a bit better * MIN_SIBLINGS_ON_CANVAS -> DEFAULT_MIN_SCALE_X * MIN_TIMEPOINTS_ON_CANVAS -> DEFAULT_MIN_SCALE_Y
…mEventHandler in grapher package * Initialized with the existing static default values
…rther zoom in is possible
tinevez
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Window to Mastodon: the Grapher Branch View
In order to avoid too much of duplicated code in Grapher and Grapher Branch, this PR adds a new class: GrapherInitializer
Since with the default max zoom in settings, it was sometimes not possible to see the labels of the branchspots, I introduced parameters and initialized the Grapher Branch View with higher max zoom in settings