Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Domain Block (IOS-5) #1198

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Add Domain Block (IOS-5) #1198

merged 8 commits into from
Jan 2, 2024

Conversation

zeitschlag
Copy link
Contributor

@zeitschlag zeitschlag commented Dec 18, 2023

Will fix #364

@zeitschlag zeitschlag marked this pull request as ready for review December 19, 2023 12:21
@zeitschlag zeitschlag requested a review from kimar December 19, 2023 12:21
@zeitschlag zeitschlag self-assigned this Dec 20, 2023
@zeitschlag zeitschlag changed the base branch from develop to ios-192-profile-about January 1, 2024 19:18
@zeitschlag zeitschlag changed the base branch from ios-192-profile-about to develop January 1, 2024 19:18
Copy link
Contributor

@kimar kimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one remark regarding missing L10n.

@zeitschlag zeitschlag merged commit 01eff2b into develop Jan 2, 2024
1 check passed
@zeitschlag zeitschlag deleted the ios-5-domain-blocks branch January 2, 2024 10:46
@zeitschlag zeitschlag added this to the 2024.01 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing block domain dropdown option on profiles
2 participants