solution #151
Open
solution #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajnova
suggested changes
Aug 28, 2020
src/deepEqual.js
Outdated
Comment on lines
23
to
27
| if (a === null && b === null) { | ||
| return true; | ||
| } else if ((a === null && b !== null) || (a !== null && b === null)) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
null === null is true, so you don't need to write such amount of code
src/deepEqual.js
Outdated
Comment on lines
40
to
43
| } else if (typeof (a[key]) !== 'object' && a[key] !== b[key]) { | ||
| return false; | ||
| } else if (typeof (a[key]) === 'object') { | ||
| const result = deepEqual(a[key], b[key]); |
There was a problem hiding this comment.
you can run your function deepEqual earlier and it will check primitives too
krajnova
approved these changes
Aug 28, 2020
irenhh
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.