solution #2189
solution #2189
Conversation
There was a problem hiding this comment.
Great job on implementing the formatDate function! 🎉 Your code meets the task requirements and handles the conversion of date formats effectively. While there was a minor issue with the logic for converting 'YY' to 'YYYY', it doesn't critically impact the functionality. For future improvements, consider using parseInt(dateObject['YY'], 10) for a more accurate comparison when determining the century. Keep up the excellent work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| dateObject['YYYY'] = | ||
| +dateObject['YY'] < 30 | ||
| ? `20${dateObject['YY']}` | ||
| : `19${dateObject['YY']}`; |
There was a problem hiding this comment.
The logic for converting 'YY' to 'YYYY' is incorrect. The expression +dateObject['YY'] < 30 will always evaluate to a boolean, which is not intended here. You should compare the numeric value of 'YY' to determine the century correctly. Consider using parseInt(dateObject['YY'], 10) for comparison.
No description provided.