solution #1350
Open
solution #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rommelua
suggested changes
Nov 24, 2023
Comment on lines
+20
to
+49
| @Override | ||
| public boolean equals(Object storageObject) { | ||
| if (storageObject == this) { | ||
| return true; | ||
| } | ||
| if (storageObject == null) { | ||
| return false; | ||
| } | ||
| if (storageObject.getClass().equals(StorageObject.class)) { | ||
| StorageObject current = (StorageObject) storageObject; | ||
| boolean keyEquals = (this.key == null && current.key == null) | ||
| || (this.key != null && this.key.equals(current.key)); | ||
| boolean valueEquals = (this.value == null && current.value == null) | ||
| || (this.value != null && this.value.equals(current.value)); | ||
| return keyEquals && valueEquals; | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| int result = 17; | ||
| result = 31 * result + (key == null ? 0 : key.hashCode()); | ||
| result = 31 * result + (value == null ? 0 : value.hashCode()); | ||
| return result; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "{" + "key=" |
There was a problem hiding this comment.
delete this
why? what is the other solution?
There was a problem hiding this comment.
make it nested class
it uses only inside `Storage, so we don't need it public
|
|
||
| public class StorageImpl<K, V> implements Storage<K, V> { | ||
|
|
||
| private final StorageObject[] storage = new StorageObject[10]; |
|
|
||
| private final StorageObject[] storage = new StorageObject[10]; | ||
|
|
||
| private int size = 0; |
There was a problem hiding this comment.
Suggested change
| private int size = 0; | |
| private int size; |
sokimaaa
suggested changes
Nov 24, 2023
Comment on lines
+20
to
+49
| @Override | ||
| public boolean equals(Object storageObject) { | ||
| if (storageObject == this) { | ||
| return true; | ||
| } | ||
| if (storageObject == null) { | ||
| return false; | ||
| } | ||
| if (storageObject.getClass().equals(StorageObject.class)) { | ||
| StorageObject current = (StorageObject) storageObject; | ||
| boolean keyEquals = (this.key == null && current.key == null) | ||
| || (this.key != null && this.key.equals(current.key)); | ||
| boolean valueEquals = (this.value == null && current.value == null) | ||
| || (this.value != null && this.value.equals(current.value)); | ||
| return keyEquals && valueEquals; | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| int result = 17; | ||
| result = 31 * result + (key == null ? 0 : key.hashCode()); | ||
| result = 31 * result + (value == null ? 0 : value.hashCode()); | ||
| return result; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "{" + "key=" |
There was a problem hiding this comment.
make it nested class
it uses only inside `Storage, so we don't need it public
Comment on lines
+9
to
+14
| private static final int PRIMARY_SIZE = 0; | ||
| private final StorageObject[] storage; | ||
| private int size; | ||
|
|
||
| public StorageImpl() { | ||
| this.size = PRIMARY_SIZE; |
There was a problem hiding this comment.
redundant, java set 0 as default for primitive
Suggested change
| private static final int PRIMARY_SIZE = 0; | |
| private final StorageObject[] storage; | |
| private int size; | |
| public StorageImpl() { | |
| this.size = PRIMARY_SIZE; | |
| private final StorageObject[] storage; | |
| private int size; | |
| public StorageImpl() { |
Comment on lines
43
to
50
| if (object == null) { | ||
| break; | ||
| } else if (object.getKey() == null && key == null) { | ||
| return (V) object.getValue(); | ||
| } else if (object.getKey() != null | ||
| && object.getKey().equals(key)) { | ||
| return (V) object.getValue(); | ||
| } |
There was a problem hiding this comment.
if statement could be simplified.
you have similar logic in each clause
Comment on lines
24
to
35
| storage[i] = storageToAdd; | ||
| size++; | ||
| break; | ||
| } else if (storage[i].getKey() == null | ||
| && storageToAdd.getKey() == null) { | ||
| storage[i] = storageToAdd; | ||
| break; | ||
| } else if (storage[i].getKey() != null | ||
| && storage[i].getKey().equals(storageToAdd.getKey())) { | ||
| storage[i] = storageToAdd; | ||
| break; | ||
| } |
sokimaaa
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.