first solution #1355
first solution #1355
Conversation
| storageSize = 0; | ||
| lastIndex = 0; |
There was a problem hiding this comment.
java do this for you already
| storageSize = 0; | |
| lastIndex = 0; |
| uniqueKey = false; | ||
| break; |
There was a problem hiding this comment.
| uniqueKey = false; | |
| break; | |
| return; |
| @Override | ||
| public void put(K key, V value) { | ||
| boolean uniqueKey = true; |
There was a problem hiding this comment.
you dont need it
| boolean uniqueKey = true; |
| keyArray[lastIndex] = key; | ||
| valueArray[lastIndex] = value; | ||
| storageSize++; | ||
| lastIndex++; |
| private K[] keyArray; | ||
| private V[] valueArray; | ||
| private int storageSize; | ||
| private int lastIndex; |
There was a problem hiding this comment.
you dont need it
| private int lastIndex; |
| } | ||
|
|
||
| @Override | ||
| public V get(K key) { | ||
| for (int i = 0; i < keyArray.length; i++) { |
There was a problem hiding this comment.
| for (int i = 0; i < keyArray.length; i++) { | |
| for (int i = 0; i < size; i++) { |
There was a problem hiding this comment.
you have size variable created specially for that purpose, so lets use it
| if ((keyArray[i] == null && key == null) | ||
| || (keyArray[i] != null && keyArray[i].equals(key))) { |
There was a problem hiding this comment.
| if ((keyArray[i] == null && key == null) | |
| || (keyArray[i] != null && keyArray[i].equals(key))) { | |
| if (key == keyArray[i] || key != null && key.equals(keyArray[i])) { |
There was a problem hiding this comment.
it's more convenient way to compare them with identic results
|
i cannot delete variable size because i cannot use in this task data structures |
|
i cannot delete variable size because i cannot use in this task data structures |
| } | ||
|
|
||
| @Override | ||
| public V get(K key) { | ||
| for (int i = 0; i < keyArray.length; i++) { |
There was a problem hiding this comment.
you have size variable created specially for that purpose, so lets use it
| if ((keyArray[i] == null && key == null) | ||
| || (keyArray[i] != null && keyArray[i].equals(key))) { |
There was a problem hiding this comment.
it's more convenient way to compare them with identic results
| public StorageImpl() { | ||
| keyArray = (K[]) new Object[ARRAY_LENGTH]; | ||
| valueArray = (V[]) new Object[ARRAY_LENGTH]; | ||
| size = 0; |
There was a problem hiding this comment.
int variables are zero by default. no need to repeat it by yourself
| size = 0; |
| } | ||
|
|
||
| @Override | ||
| public V get(K key) { | ||
| for (int i = 0; i < keyArray.length; i++) { |
| if ((keyArray[i] == null && key == null) | ||
| || (keyArray[i] != null && keyArray[i].equals(key))) { |
…ion of the loop of size value
No description provided.